Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(neon): Do not panic when dropping a Root if the VM has shutdown #677

Merged
merged 2 commits into from
Feb 2, 2021
Merged

fix(neon): Do not panic when dropping a Root if the VM has shutdown #677

merged 2 commits into from
Feb 2, 2021

Conversation

kjvalencik
Copy link
Member

@kjvalencik kjvalencik commented Jan 29, 2021 •
edited
Loading

Currently, if a Root is inside an EventQueue task and the VM is stopped, the user will never have an opportunity to clean up the Root. In this case, it's not a leak because the value will be deleted as the VM exits.

This PR introduces a new IS_RUNNING thread local value. It is initialized as true during module initialization and set to false the first time an EventQueue callback receives a None for Env.

If the value is false, the Drop impl on Root will not panic.

dherman
dherman approved these changes Feb 2, 2021
View reviewed changes
Copy link
Collaborator

@dherman dherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@kjvalencik kjvalencik merged commit 0a35c58 into main Feb 2, 2021
@kjvalencik kjvalencik deleted the kv/no-panic-shutdown branch February 2, 2021 15:45
This was referenced Jun 6, 2021
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dherman dherman dherman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kjvalencik @dherman